Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package kmodes #1447

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

New package kmodes #1447

wants to merge 5 commits into from

Conversation

jvachier
Copy link

@jvachier jvachier commented Nov 30, 2024

Adding new package called 'Kmodes'.

File modified:

  • Kaggle_requirements.txt

File added to tests/:

  • test_kmodes.py

Copy link

google-cla bot commented Nov 30, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@jvachier
Copy link
Author

Hi @djherbis,

I hope you are well.

Just to make sure that my PR correctly follow your standards to be reviewed correctly.

Please let me know if you need any further information.

Thank you very much in advance.

@djherbis djherbis requested a review from calderjo January 2, 2025 15:10
@calderjo
Copy link
Contributor

Hey have you tried the package manager! we strongly encourage using this before opening a new request for a new package.

https://www.kaggle.com/discussions/product-announcements/532336

@jvachier
Copy link
Author

Hey have you tried the package manager! we strongly encourage using this before opening a new request for a new package.

https://www.kaggle.com/discussions/product-announcements/532336

Hi @calderjo

Thank you for your message. I was not aware of this package, and it seems very useful. Next time, I will use it first.

About kmodes:
During a competition, as we cannot use internet, I did install kmodes locally using pip. However, for some reasons it was not possible. Therefore, after checking the Kaggle requirements file and seeing that kmodes was not installed, I did create this PR.

Please let me know if we can go ahead with this PR and add kmodes to the Kaggle requirements.

@calderjo
Copy link
Contributor

calderjo commented Jan 21, 2025

@jvachier i think you might be misunderstanding what the package manager is.

package manager is a way for you to include packages not found in our base image for offline competitions.

you provide a requirement file, and we handle installation.

I recommend that you use this first before opening a PR.

@jvachier
Copy link
Author

@jvachier i think you might be misunderstanding what the package manager is.

package manager is a way for you to include packages not found in our base image for offline competitions.

you provide a requirement file, and we handle installation.

I recommend that you use this first before opening a PR.

Hi @calderjo,

Thank you for your message.

The package manager is there to install packages offline using pip. It was recently introduced and I was not aware of it.

Let me clarify my previous comment:
Other methods have been previously used to install packages offline using pip. For example,

Unfortunately, in my case, these methods did not work. As a result, I raised this PR with the associated test.

Next time I participate to a competition, such as https://www.kaggle.com/competitions/child-mind-institute-problematic-internet-use, I am happy to use the package manager.

Please let me know, if we should close this PR.

@calderjo
Copy link
Contributor

@jvachier i'm curious were you able to install the package using the package manager, or did you encounter some issues

@jvachier
Copy link
Author

jvachier commented Feb 1, 2025

@jvachier i'm curious were you able to install the package using the package manager, or did you encounter some issues

Hi @calderjo as said, I did not use the package manager for this competition as I did not know about it, and that's why, after using other methods that did not work, I created this PR.

As mentioned in my previous comment, next time I participate to a competition, I will use the package manager.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants