-
Notifications
You must be signed in to change notification settings - Fork 969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New package kmodes #1447
base: main
Are you sure you want to change the base?
New package kmodes #1447
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @djherbis, I hope you are well. Just to make sure that my PR correctly follow your standards to be reviewed correctly. Please let me know if you need any further information. Thank you very much in advance. |
Hey have you tried the package manager! we strongly encourage using this before opening a new request for a new package. https://www.kaggle.com/discussions/product-announcements/532336 |
Hi @calderjo Thank you for your message. I was not aware of this package, and it seems very useful. Next time, I will use it first. About kmodes: Please let me know if we can go ahead with this PR and add kmodes to the Kaggle requirements. |
@jvachier i think you might be misunderstanding what the package manager is. package manager is a way for you to include packages not found in our base image for offline competitions. you provide a requirement file, and we handle installation. I recommend that you use this first before opening a PR. |
Hi @calderjo, Thank you for your message. The package manager is there to install packages offline using pip. It was recently introduced and I was not aware of it. Let me clarify my previous comment:
Unfortunately, in my case, these methods did not work. As a result, I raised this PR with the associated test. Next time I participate to a competition, such as https://www.kaggle.com/competitions/child-mind-institute-problematic-internet-use, I am happy to use the package manager. Please let me know, if we should close this PR. |
@jvachier i'm curious were you able to install the package using the package manager, or did you encounter some issues |
Hi @calderjo as said, I did not use the package manager for this competition as I did not know about it, and that's why, after using other methods that did not work, I created this PR. As mentioned in my previous comment, next time I participate to a competition, I will use the package manager. |
Adding new package called 'Kmodes'.
File modified:
File added to tests/: